New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SA1013: overhaul check #1213
Labels
Comments
This isn't actually a problem, because the |
dominikh
added a commit
that referenced
this issue
Apr 25, 2022
dominikh
added a commit
that referenced
this issue
Apr 25, 2022
dominikh
added a commit
that referenced
this issue
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
False positives
We should make sure that we're actually calling io.Seeker.Seek, and not some other method named Seek, to avoid false positives like
In fact we even look at package-level functions in other packages, not just methods.
Furthermore, we look for the use of
io.SeekStart
etc, without making sure that this refers to a package level constant or the actual stdlibio
package.False negatives
We only look for the io.Seek* constants, not the deprecated
os
equivalents.The text was updated successfully, but these errors were encountered: