Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staticcheck: trim the cache #1283

Closed
cespare opened this issue Jun 3, 2022 · 6 comments
Closed

staticcheck: trim the cache #1283

cespare opened this issue Jun 3, 2022 · 6 comments
Labels
bug

Comments

@cespare
Copy link

cespare commented Jun 3, 2022

On some CI machines the staticcheck cache has grown to many GB. I took at look at the code and saw that the cache code is copied from the Go tool. However, Cache.Trim is never called (and I can see that there is no trim.txt in the cache directory).

Is this intentional? I'm guessing it's a bug.

I'm using v0.3.0 but I don't think the behavior has changed since then.
@cespare cespare added bug needs-triage Newly filed issue that needs triage labels Jun 3, 2022
@dominikh dominikh removed the needs-triage Newly filed issue that needs triage label Jun 3, 2022
@dominikh
Copy link
Owner

dominikh commented Jun 3, 2022

That would be a bug. Will investigate.

@dominikh
Copy link
Owner

dominikh commented Jun 3, 2022

It looks like we lost the call to Trim in 5cfc85b.

@dominikh
Copy link
Owner

dominikh commented Jun 3, 2022

Fixed on master (which is Go 1.18 only). Will be backported to a bugfix release in a couple days.

@cespare
Copy link
Author

cespare commented Jun 3, 2022

Thanks!

@cespare
Copy link
Author

cespare commented Jul 26, 2022

Will be backported to a bugfix release in a couple days.

@dominikh ping on this. Looks like this fix isn't in any release yet?

dominikh added a commit that referenced this issue Jul 29, 2022
@dominikh
lintcmd: trim cache
ae2dc16 
Closes gh-1283

(cherry picked from commit ec2239c)
@dominikh
Copy link
Owner

@cespare Thanks for the ping. It's now part of https://github.com/dominikh/go-tools/releases/tag/v0.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dominikh @cespare